Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .fallowrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@
"file": "packages/provider-limrun/src/index.ts",
"exports": ["LimrunIosCommandExecution"]
},
{
"comment": "#1959 gave every contracts vocabulary module its own entry subpath and moved all ~230 value-importers onto them, so `./platform` and `./interaction` now carry zero value consumers — every re-export on them reads as unused. They stay as the compatibility surface for the ~490 type-only importers the granularization deliberately left alone (type imports are erased, so they cost nothing to load). Scoped to these two façades rather than listed symbol-by-symbol because the property is per-file: nothing on them is value-consumed any more. Retiring them entirely — moving the type-only importers too and deleting the files — is the follow-up that makes this entry unnecessary.",
"file": "packages/contracts/src/facades/{platform,interaction}.ts",
"exports": ["*"]
},
{
"comment": "Converting the contracts façades from `export *` to explicit named re-exports (the pin-table retirement) made these individually visible to --production analysis for the first time; a bare star previously hid them from this exact check. GESTURE_INITIAL_ANGLE_DEGREES/GESTURE_SAMPLE_INTERVAL_MS/INTERACTION_GUARANTEES/INTERACTION_PATH_IDS/parseAndroidInputMethodPackage/isRecordingExportQuality have same-package test-tree consumers (invisible to --production, mirroring the packages/{ad-script,maestro} entry above); the rest currently have none. Kept rather than narrowed here so the façade's re-export surface stays byte-identical to the symbol set the retired pin table asserted — narrowing the surface is a follow-up with its own review, not a side effect of this mechanical conversion. The last five (COORDINATE_GESTURE_KINDS, normalizePublicGesture, DEFAULT_DRAG_*) are #1567's drag vocabulary, surfaced the same way by the same conversion and kept for the same reason.",
"file": "packages/contracts/src/facades/{client,command,divergence,interaction,platform,recording}.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/ad-script/src/internal/script.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AppError } from '@agent-device/kernel/errors';
import { recordingQualityInputToExportQuality } from '@agent-device/contracts/recording';
import { describeReplayGestureArityError } from '@agent-device/contracts/interaction';
import { describeReplayGestureArityError } from '@agent-device/contracts/gesture-normalization';
import {
RETIRED_SCREENSHOT_MAX_SIZE,
readScreenshotScriptFlag,
Expand Down
12 changes: 7 additions & 5 deletions packages/capture-kit/src/app-log-live-handle.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { AppError } from '@agent-device/kernel/errors';
import type {
AppLogCompletion,
AppLogLiveHandle,
AppLogLiveSnapshot,
} from '@agent-device/contracts/app-log-runtime';
import {
isConfirmedCleanup,
type AppLogCompletion,
type AppLogLiveHandle,
type AppLogLiveSnapshot,
type CleanupOutcome,
type FinishOutcome,
} from '@agent-device/contracts/platform';
isConfirmedCleanup,
} from '@agent-device/contracts/durable-resource';

type AppLogLiveHandleImplementation = Readonly<{
inspect(): AppLogLiveSnapshot;
Expand Down
10 changes: 5 additions & 5 deletions packages/capture-kit/src/app-log-pid-runtime.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { DeviceInfo } from '@agent-device/kernel/device';
import { expect, test, vi } from 'vitest';
import {
type AppLogBackgroundProcess,
type AppLogRuntimeHost,
type DurableDescriptorCodec,
} from '@agent-device/contracts/platform';
import type {
AppLogBackgroundProcess,
AppLogRuntimeHost,
} from '@agent-device/contracts/app-log-runtime';
import type { DurableDescriptorCodec } from '@agent-device/contracts/durable-resource-envelope';
import {
createDurableResourceEnvelope,
encodeDurableDescriptor,
Expand Down
2 changes: 1 addition & 1 deletion packages/capture-kit/src/app-log-pid-runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import type {
RuntimeFacts,
RuntimeOwnerRef,
} from '@agent-device/contracts/platform';
import { localRuntimeOwner, sameRuntimeOwner } from '@agent-device/contracts/platform';
import { localRuntimeOwner, sameRuntimeOwner } from '@agent-device/contracts/platform-runtime';
import type { LogBackend } from '@agent-device/contracts/observability';
import { createAppLogRecoveryOperations, createAppLogStartResult } from './app-log-runtime.ts';
import {
Expand Down
16 changes: 8 additions & 8 deletions packages/capture-kit/src/app-log-runtime.test.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import assert from 'node:assert/strict';
import { test, vi } from 'vitest';
import { AppError } from '@agent-device/kernel/errors';
import {
type AppLogCompletion,
type AppLogBackgroundProcessRequest,
type AppLogProcessOwnership,
type AppLogProcessTransport,
type AppLogRuntimeHost,
type DurableDescriptorCodec,
} from '@agent-device/contracts/platform';
import type {
AppLogBackgroundProcessRequest,
AppLogCompletion,
AppLogProcessOwnership,
AppLogProcessTransport,
AppLogRuntimeHost,
} from '@agent-device/contracts/app-log-runtime';
import type { DurableDescriptorCodec } from '@agent-device/contracts/durable-resource-envelope';
import { APP_LOG_ENVELOPE_FIXTURE } from './durable-resource-envelope.fixtures.ts';
import { createAppLogLiveHandle } from './app-log-live-handle.ts';
import {
Expand Down
27 changes: 14 additions & 13 deletions packages/capture-kit/src/app-log-runtime.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import {
PendingTransferGuard,
type AppLogCompletion,
type AppLogLiveHandle,
type AppLogProcessMarkerReadOutcome,
type AppLogRuntimeOperations,
type AppLogStartResult,
type CleanupOutcome,
type DurableDescriptorCodec,
type DurableResourceEnvelope,
type ReattachOutcome,
type ResourceOwnershipFence,
} from '@agent-device/contracts/platform';
import type {
AppLogCompletion,
AppLogLiveHandle,
AppLogProcessMarkerReadOutcome,
AppLogRuntimeOperations,
AppLogStartResult,
} from '@agent-device/contracts/app-log-runtime';
import { PendingTransferGuard } from '@agent-device/contracts/async-lifecycle';
import type { CleanupOutcome, ReattachOutcome } from '@agent-device/contracts/durable-resource';
import type {
DurableDescriptorCodec,
DurableResourceEnvelope,
} from '@agent-device/contracts/durable-resource-envelope';
import type { ResourceOwnershipFence } from '@agent-device/contracts/platform-runtime';
import { decodeDurableDescriptor } from './durable-descriptor-codec.ts';

const APP_LOG_RESOURCE_KIND = 'app-log' as const;
Expand Down
18 changes: 10 additions & 8 deletions packages/capture-kit/src/durable-resource-envelope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ import {
type Platform,
} from '@agent-device/kernel/device';
import type { JsonObject } from '@agent-device/contracts/client';
import type {
DurableDescriptorCodec,
DurableEnvelopeDecodeOutcome,
DurableResourceEnvelope,
DurableResourceLifecycleState,
EncodedDurableDescriptor,
} from '@agent-device/contracts/durable-resource-envelope';
import {
localRuntimeOwner,
providerRuntimeOwner,
type DurableDescriptorCodec,
type DurableEnvelopeDecodeOutcome,
type DurableResourceEnvelope,
type DurableResourceLifecycleState,
type EncodedDurableDescriptor,
type ResourceOwnershipFence,
type RuntimeOwnerRef,
} from '@agent-device/contracts/platform';
localRuntimeOwner,
providerRuntimeOwner,
} from '@agent-device/contracts/platform-runtime';
import { freezeJsonObject, isBoundedJsonObject } from './durable-json.ts';

const DURABLE_RESOURCE_ENVELOPE_VERSION = 1 as const;
Expand Down
14 changes: 8 additions & 6 deletions packages/capture-kit/src/screen-recording-live-handle.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import { AppError } from '@agent-device/kernel/errors';
import {
isConfirmedCleanup,
type CleanupOutcome,
type FinishOutcome,
type RecordingGestureEvent,
type ScreenRecordingCompletion,
type ScreenRecordingLiveHandle,
type ScreenRecordingLiveSnapshot,
} from '@agent-device/contracts/platform';
isConfirmedCleanup,
} from '@agent-device/contracts/durable-resource';
import type {
RecordingGestureEvent,
ScreenRecordingCompletion,
ScreenRecordingLiveHandle,
ScreenRecordingLiveSnapshot,
} from '@agent-device/contracts/screen-recording-runtime';
import type { GestureReferenceFrame } from '@agent-device/contracts/interaction';

type ScreenRecordingLiveHandleImplementation = Readonly<{
Expand Down
Loading
Loading