Skip to content

fix(android): update snapshot quality lifecycle import - #1980

Merged
thymikee merged 1 commit into
mainfrom
fix/android-snapshot-quality-lifecycle-import
Aug 23, 2026
Merged

fix(android): update snapshot quality lifecycle import#1980
thymikee merged 1 commit into
mainfrom
fix/android-snapshot-quality-lifecycle-import

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Update the snapshot quality test to import session reset from its lifecycle owner after #1974 extracted that API. This repairs the deterministic Typecheck and FreeRange failures currently affecting main and unrelated PR merge queues.

Validation

  • pnpm typecheck
  • pnpm vitest run src/platforms/android/__tests__/snapshot-quality.test.ts
  • pnpm check:affected --run

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 23, 2026
@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.37 MB 2.37 MB 0 B
JS gzip 797.9 kB 797.9 kB 0 B
npm tarball 919.3 kB 919.3 kB 0 B
npm unpacked 3.19 MB 3.19 MB 0 B

npm unpacked components

Component Base Current Diff
JS / dist source 2.52 MB 2.52 MB 0 B
Apple runner source/project 564.3 kB 564.3 kB 0 B
macOS helper source 54.5 kB 54.5 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 44.5 kB 44.5 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.5 ms 27.7 ms +0.2 ms
CLI --help 79.3 ms 78.9 ms -0.4 ms

Top changed chunks: no changes in the largest emitted chunks.

Top changed packed files

No changed packed files.

@thymikee
thymikee merged commit d1fc80f into main Aug 23, 2026
27 checks passed
@thymikee
thymikee deleted the fix/android-snapshot-quality-lifecycle-import branch August 23, 2026 16:08
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-23 16:08 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant