Skip to content

fix: avoid deprecated object form of CommonActions.navigate on tab press #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagobrez merged 2 commits into from
Jun 16, 2026
Merged

fix: avoid deprecated object form of CommonActions.navigate on tab press #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a27f85
fix(react-navigation): use navigate(name, params) to avoid deprecatio…
rayabelcode Jun 11, 2026
5dd35da
chore: bump package versions and add changeset
thiagobrez Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-taxes-go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@bottom-tabs/react-navigation': patch
---

Fix deprecated object argument on CommonActions.navigate
2 changes: 1 addition & 1 deletion apps/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@bottom-tabs/react-navigation": "*",
"@react-navigation/bottom-tabs": "^7.15.9",
"@react-navigation/devtools": "^7.0.44",
"@react-navigation/native": "^7.2.2",
"@react-navigation/native": "^7.3.0",
"@react-navigation/native-stack": "^7.14.11",
"@react-navigation/stack": "^7.8.10",
"color": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-navigation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"access": "public"
},
"devDependencies": {
"@react-navigation/native": "^7.2.2",
"@react-navigation/native": "^7.3.0",
"@types/color": "^4.2.0",
"jest": "^29.7.0",
"react": "^19.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-navigation/src/views/NativeBottomTabView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default function NativeBottomTabView({
return;
} else {
navigation.dispatch({
...CommonActions.navigate(route),
...CommonActions.navigate(route.name, route.params),
target: state.key,
});
}
Expand Down
55 changes: 53 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2782,7 +2782,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@bottom-tabs/react-navigation@workspace:packages/react-navigation"
dependencies:
"@react-navigation/native": "npm:^7.2.2"
"@react-navigation/native": "npm:^7.3.0"
"@types/color": "npm:^4.2.0"
color: "npm:^5.0.0"
jest: "npm:^29.7.0"
Expand Down Expand Up @@ -5663,6 +5663,24 @@ __metadata:
languageName: node
linkType: hard

"@react-navigation/core@npm:^7.20.0":
version: 7.20.0
resolution: "@react-navigation/core@npm:7.20.0"
dependencies:
"@react-navigation/routers": "npm:^7.6.0"
escape-string-regexp: "npm:^4.0.0"
fast-deep-equal: "npm:^3.1.3"
nanoid: "npm:^3.3.11"
query-string: "npm:^7.1.3"
react-is: "npm:^19.1.0"
use-latest-callback: "npm:^0.2.4"
use-sync-external-store: "npm:^1.5.0"
peerDependencies:
react: ">= 18.2.0"
checksum: 10/037f11520ed52aa5285c9b0dcba414c589643812a494aa819a81342d60adae2adb7e014fb4a76ce36b34630c5eecbc5e0c244e4c191091d03c9c576fa0fbfbbe
languageName: node
linkType: hard

"@react-navigation/devtools@npm:^7.0.44":
version: 7.0.44
resolution: "@react-navigation/devtools@npm:7.0.44"
Expand Down Expand Up @@ -5782,6 +5800,23 @@ __metadata:
languageName: node
linkType: hard

"@react-navigation/native@npm:^7.3.0":
version: 7.3.1
resolution: "@react-navigation/native@npm:7.3.1"
dependencies:
"@react-navigation/core": "npm:^7.20.0"
escape-string-regexp: "npm:^4.0.0"
fast-deep-equal: "npm:^3.1.3"
nanoid: "npm:^3.3.11"
standard-navigation: "npm:^0.0.7"
use-latest-callback: "npm:^0.2.4"
peerDependencies:
react: ">= 18.2.0"
react-native: "*"
checksum: 10/ca5afc5a4365b02c59cfb5c5c1338258d4679f9f65bf185afa36badf84cc20a07c0414a9c6fcbc34bebd94467125ccdab7ded832dbe05b1509ce84f809c7ed54
languageName: node
linkType: hard

"@react-navigation/routers@npm:^7.5.1":
version: 7.5.1
resolution: "@react-navigation/routers@npm:7.5.1"
Expand All @@ -5800,6 +5835,15 @@ __metadata:
languageName: node
linkType: hard

"@react-navigation/routers@npm:^7.6.0":
version: 7.6.0
resolution: "@react-navigation/routers@npm:7.6.0"
dependencies:
nanoid: "npm:^3.3.11"
checksum: 10/bc92608159d13c73991d2947b444da0040707f930c67712b31088e0eb9a5bf2c422afa54495066828b08100803bd24675b121c550430fee92fe6a189fea433d2
languageName: node
linkType: hard

"@react-navigation/stack@npm:^7.8.10":
version: 7.8.10
resolution: "@react-navigation/stack@npm:7.8.10"
Expand Down Expand Up @@ -16086,7 +16130,7 @@ __metadata:
"@react-native/typescript-config": "npm:0.81.4"
"@react-navigation/bottom-tabs": "npm:^7.15.9"
"@react-navigation/devtools": "npm:^7.0.44"
"@react-navigation/native": "npm:^7.2.2"
"@react-navigation/native": "npm:^7.3.0"
"@react-navigation/native-stack": "npm:^7.14.11"
"@react-navigation/stack": "npm:^7.8.10"
"@rnx-kit/metro-config": "npm:^2.1.0"
Expand Down Expand Up @@ -17922,6 +17966,13 @@ __metadata:
languageName: node
linkType: hard

"standard-navigation@npm:^0.0.7":
version: 0.0.7
resolution: "standard-navigation@npm:0.0.7"
checksum: 10/7c04912a93cd09d3e19c8c47a52f7808b53bc1b6fb897e21261e3401cb4340d505e9e4e387ac50662aa0534cdb2d091c03aeb5efc72fcd678925a3af5bbfce74
languageName: node
linkType: hard

"statuses@npm:2.0.1":
version: 2.0.1
resolution: "statuses@npm:2.0.1"
Expand Down
Loading