Skip to content

fix: version inconsistency #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurali97 merged 2 commits into from
Aug 20, 2026
Merged

fix: version inconsistency #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff64e6f
fix: version inconsistency
hurali97 Aug 19, 2026
ad90028
fix: test
hurali97 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://unpkg.com/@changesets/config@3.0.4/schema.json",
"$schema": "https://unpkg.com/@changesets/config@4.0.0/schema.json",
"changelog": [
"@changesets/changelog-github",
{ "repo": "callstack/react-native-brownfield" }
Expand All @@ -17,16 +17,7 @@
"linked": [],
"access": "public",
"baseBranch": "main",
"ignore": [
"react-native-brownfield-docs",
"@callstack/brownfield-example-android-app",
"@callstack/brownfield-example-ios-app",
"@callstack/brownfield-example-rn-app",
"@callstack/brownfield-example-expo-app-56",
"@callstack/brownfield-gradle-plugin-react",
"@callstack/brownfield-example-shared-tests",
"@callstack/brownfield-example-expo-app-57"
],
"ignore": [],

@artus9033 artus9033 Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is valid

@hurali97 hurali97 Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this migration guide by changeset, they advise against declaring ignores because with v3 the private packages are not versioned and published.

https://changesets.dev/guide/migration#opt-in-to-versioning-private-packages

"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"onlyUpdatePeerDependentsWhenOutOfRange": true,
"updateInternalDependents": "always"
Expand Down
9 changes: 9 additions & 0 deletions .changeset/fix-workspace-publish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@callstack/react-native-brownfield": patch
"@callstack/brownie": patch
"@callstack/brownfield-navigation": patch
"brownfield": patch
"@callstack/brownfield-cli": patch
---

Fix npm publishing by upgrading to Changesets v3 (Yarn rewrites `workspace:` ranges on publish) and correcting package `repository` metadata required for npm provenance.
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
run: yarn build

- name: Create Release Pull Request or Publish to NPM
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@22ccf9aa43179fe9e27dc62e575971d28cce197c # v2.0.0
with:
version: yarn ci:version
publish: yarn ci:publish
commit: 'chore(release): version packages'
title: 'chore(release): version packages'
version-script: yarn ci:version
publish-script: yarn ci:publish
commit-message: 'chore(release): version packages'
pr-title: 'chore(release): version packages'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions apps/brownfield-example-shared-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"react-test-renderer": ">=18"
},
"devDependencies": {
"@babel/runtime": "^7.25.0",
"@callstack/brownfield-navigation": "workspace:^",
"@callstack/react-native-brownfield": "workspace:^",
"@testing-library/react-native": "^13.3.3",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
},
"packageManager": "yarn@4.12.0",
"dependencies": {
"@changesets/changelog-github": "^0.6.0",
"@changesets/cli": "^2.30.0",
"@changesets/changelog-github": "^1.0.0",
"@changesets/cli": "^3.0.1",
"@expo/config-plugins": "^56.0.8"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions packages/brownfield-navigation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"author": "Hur Ali",
"description": "Brownfield navigation helpers for React Native",
"homepage": "https://github.com/callstack/react-native-brownfield",
"repository": {
"url": "git+https://github.com/callstack/react-native-brownfield.git"
},
"main": "lib/commonjs/index",
"module": "lib/module/index",
"types": "./lib/typescript/commonjs/src/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/brownfield/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"homepage": "https://oss.callstack.com/react-native-brownfield",
"repository": {
"url": "git+https://github.com/callstack/react-native-brownfield/packages/brownfield"
"url": "git+https://github.com/callstack/react-native-brownfield.git"
},
"description": "Brownfield CLI for React Native, gathering all packages of the RN brownfield ecosystem",
"exports": {
Expand Down
Loading
Loading