Skip to content

Improve source map symbolication#1392

Draft
dannyhw wants to merge 2 commits into
mainfrom
dannyhw/source-map-symbolication-fixes
Draft

Improve source map symbolication#1392
dannyhw wants to merge 2 commits into
mainfrom
dannyhw/source-map-symbolication-fixes

Conversation

@dannyhw

@dannyhw dannyhw commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

WIP based on patches received for resolving errors to editor paths etc, still needs extensive testing

Summary

  • improve /open-stack-frame handling by resolving macOS editor commands earlier and mapping feature-app source paths when possible
  • make symbolication tolerant of bundle and hot-update frames, skip known React runtime frames, and use source map contents for code frames when available
  • allow the Rspack dev server to fetch remote source maps from bundle URLs or Module Federation remote config when the local compiler cannot provide one

Validation

  • node_modules/.bin/biome check --write packages/dev-server/src/plugins/devtools/devtoolsPlugin.ts packages/dev-server/src/plugins/symbolicate/Symbolicator.ts packages/dev-server/src/plugins/symbolicate/sybmolicatePlugin.ts packages/repack/src/commands/rspack/start.ts
  • packages/dev-server/node_modules/.bin/tsc --noEmit -p packages/dev-server/tsconfig.json
  • packages/repack/node_modules/.bin/tsc --noEmit -p packages/repack/tsconfig.json
  • git diff --check

Note: the local pre-commit hook attempted to run pnpm through the bundled runtime and stopped before checks with a non-interactive modules purge prompt, so the commit was created after running the relevant checks directly.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
repack-website Ready Ready Preview, Comment Jul 2, 2026 12:01pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 799d911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread packages/dev-server/src/plugins/devtools/devtoolsPlugin.ts Fixed
Comment thread packages/repack/src/commands/rspack/start.ts Fixed
Comment thread packages/dev-server/src/plugins/devtools/devtoolsPlugin.ts Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants