test: add unit tests for remaining app workers (#489)#614
Closed
phoenix-server wants to merge 5 commits intomainfrom
Closed
test: add unit tests for remaining app workers (#489)#614phoenix-server wants to merge 5 commits intomainfrom
phoenix-server wants to merge 5 commits intomainfrom
Conversation
Add dorny/paths-filter gate so lint, build-check, and both test jobs only run when source-affecting files change (src/, test/, package.json, tsconfigs, Dockerfiles, etc.). Metadata checks (commit-lint, changeset-check) remain unconditional. Also restrict commit-lint to PRs/workflow_dispatch to avoid false positives on squash-merge commits pushed to main, fix post-tests Coveralls parallel-finished to not fire on skipped test runs, and bump actions/checkout + actions/setup-node from v3 to v4.
…ness Agent-Logs-Url: https://github.com/cameri/nostream/sessions/5e3c60f2-1798-47a5-b25a-45c990bfb6bd Co-authored-by: cameri <378886+cameri@users.noreply.github.com>
Resolves conflicts by: - Keeping path filter optimization (changes job + conditional skipping) - Adopting pnpm package manager from main - Upgrading GitHub Actions to v4 for security/performance - Updating lock file path from package-lock.json to pnpm-lock.yaml - Changing npm commands to pnpm equivalents - Removing redundant npm-based changeset entry
- Adds comprehensive unit tests for AppWorker (22 test cases, all passing) - Adds unit tests for StaticMirroringWorker (30+ test cases) - Adds unit tests for App cluster coordinator (25+ test cases) - Tests cover lifecycle (start, stop, error handling) - Tests cover configuration and environment variables - Tests cover cluster message broadcasting and worker management - Dependency stubs (repositories, adapters, services) Increases test coverage for src/app/worker.ts and src/app/app.ts. Partial coverage for src/app/static-mirroring-worker.ts. Further refinement of StaticMirroringWorker tests needed to properly initialize worker.config before testing isUserAdmitted method. Acceptance criteria for issue #489: - Worker lifecycle tests: ✅ - Error handling: ✅ - Dependencies stubbed: ✅ - npm run cover:unit passes: Partial (need ESM loader configuration)
|
Collaborator
|
coverage: 66.605% (+1.7%) from 64.937% — chore/optimize-ci-path-filters into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive unit tests for the remaining app-level workers to address issue #489.
Changes
Test Coverage
Status
Note
The test suite requires the ESM loader to run properly due to TypeScript parameter properties:
NODE_OPTIONS="--loader ts-node/esm --experimental-specifier-resolution=node" npm run test:unitCloses #489