Public Sequencer: Add SV UI Write Path for Validator Permissioning#5667
Open
pasindutennage-da wants to merge 22 commits into
Open
Public Sequencer: Add SV UI Write Path for Validator Permissioning#5667pasindutennage-da wants to merge 22 commits into
pasindutennage-da wants to merge 22 commits into
Conversation
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[static] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
| @@ -0,0 +1,99 @@ | |||
| package org.lfdecentralizedtrust.splice.integration.tests | |||
Contributor
Author
There was a problem hiding this comment.
Until canton-network/splice-shared-gha#77 is accepted, this test will fail in the CI
But locally it passes
Contributor
There was a problem hiding this comment.
testing tip: You can bump the submodule to your PR before it's merged to check things end to end.
| @@ -149,6 +149,22 @@ jobs: | |||
| oss_only: ${{ inputs.oss_only }} | |||
| secrets: inherit | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Design choice: I opted to have a seperate job for this, so that permissionsynchronizerbackend test don't have to run start-frontend.sh.
| @@ -26,6 +26,10 @@ on: | |||
| type: boolean | |||
| required: false | |||
| default: false | |||
Contributor
Author
There was a problem hiding this comment.
reason: for permissioned frontend test, we need to pass -p new param to start-frontend.sh
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
| run_tests=0 | ||
| permissioned="false" | ||
|
|
||
| while getopts "hdapvsmtl" arg; do |
Contributor
Author
There was a problem hiding this comment.
Did a bit of cleanup
moritzkiefer-da
approved these changes
May 26, 2026
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
thx please double check the regex before merging
| @@ -0,0 +1,99 @@ | |||
| package org.lfdecentralizedtrust.splice.integration.tests | |||
Contributor
There was a problem hiding this comment.
testing tip: You can bump the submodule to your PR before it's merged to check things end to end.
| import { useSvAdminClient } from '../contexts/SvAdminServiceContext'; | ||
| import { useSvConfig } from '../utils'; | ||
|
|
||
| const VALID_PARTY_ID_REGEX = /^[a-zA-Z0-9\-_]+::[a-zA-Z0-9]+$/; |
Contributor
There was a problem hiding this comment.
where did you get these regex from? I'm pretty sure a:b::namespace is valid for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5288
Note: Until canton-network/splice-shared-gha#77 is merged, the CI will fail in this PR