Skip to content

chore: Fix POM flattening - #16

Merged
mlakov merged 1 commit into
mainfrom
chore/fix-pom-flattening
Jul 30, 2026
Merged

chore: Fix POM flattening#16
mlakov merged 1 commit into
mainfrom
chore/fix-pom-flattening

Conversation

@mlakov

@mlakov mlakov commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Fix POM Flattening for Maven Release

🔧 Chore: Corrects the POM flattening configuration to ensure proper artifact deployment to Maven Central.

Changes

  • pom.xml: Moved the <scm> block from the root POM to the child module POM, and upgraded flatten-maven-plugin from version 1.7.3 to 1.8.0.
  • cds-feature-ord/pom.xml: Added the <scm> block (moved from root POM) and introduced an explicit flatten-maven-plugin execution configured with ossrh flatten mode, ensuring the published POM is properly resolved for OSSRH/Maven Central deployment.
  • .github/workflows/release.yml: Added maven-extra-args: '-f cds-feature-ord/pom.xml' to the Deploy step, targeting the child module POM directly during release, and removed a duplicate maven-version entry.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.29.9

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: cb6ebee0-8c24-11f1-9a0d-402973121e2b
  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.opened
  • Output Template: Default Template

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two substantive issues were found: a malformed XML tag in cds-feature-ord/pom.xml (a stray > that will break all Maven invocations on this module), and a logic error in the release workflow where -f cds-feature-ord/pom.xml replaces the root POM, causing the deploy-release profile — and with it GPG signing and Maven Central publishing — to never be applied during deployment.

PR Bot Information

Version: 1.29.9

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: cb6ebee0-8c24-11f1-9a0d-402973121e2b
  • Event Trigger: pull_request.opened
  • Experiment Variant: control

Comment thread cds-feature-ord/pom.xml Outdated
Comment thread .github/workflows/release.yml Outdated
@mlakov
mlakov force-pushed the chore/fix-pom-flattening branch 2 times, most recently from 183c8cd to cf4caf0 Compare July 30, 2026 14:50
@mlakov
mlakov force-pushed the chore/fix-pom-flattening branch from cf4caf0 to 7c5bf58 Compare July 30, 2026 14:51

@zongqichen zongqichen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlakov
mlakov merged commit 54b5875 into main Jul 30, 2026
8 checks passed
@mlakov
mlakov deleted the chore/fix-pom-flattening branch July 30, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants