Remove monorepo skill copies now sourced from boxel-skills#5601
Open
jurgenwerk wants to merge 2 commits into
Open
Remove monorepo skill copies now sourced from boxel-skills#5601jurgenwerk wants to merge 2 commits into
jurgenwerk wants to merge 2 commits into
Conversation
ember-best-practices and boxel-ui-component-discovery were adopted into cardstack/boxel-skills and ship via the boxel-cli plugin as of v0.0.30, so the monorepo copies are duplicates. Deleted: - .agents/skills/ember-best-practices (factory fallback copy) - .claude/skills/ember-best-practices (repo dev-facing copy) - packages/software-factory/.agents/skills/boxel-ui-component-discovery (orchestrator-flavored copy) The factory skill loader references both by name and now resolves them from packages/boxel-cli/plugin/skills/ (fallback #1); loader comments and the software-factory AGENTS.md/CLAUDE.md skill-dir docs are updated to match. Monorepo-root .agents/skills/ is left as an (empty) fallback slot. Also clears PENDING_BOXEL_REFERENCES: qunit-testing.md shipped in boxel-skills v0.0.30, which the curated-references guard test was failing on; the pending-list test now handles the empty (normal) state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rly-return) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jurgenwerk
marked this pull request as ready for review
July 24, 2026 07:01
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b89c70da42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
FadhlanR
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-best-practicesandboxel-ui-component-discoverywere adopted into cardstack/boxel-skills (CS-12270) and now ship intopackages/boxel-cli/plugin/skills/via the v0.0.30 pin. The monorepo copies are duplicates, so this removes them:.agents/skills/ember-best-practices— the factory fallback copy.claude/skills/ember-best-practices— the repo's dev-facing copypackages/software-factory/.agents/skills/boxel-ui-component-discovery— the orchestrator-flavored copyThe factory skill loader references both by name and resolves them from
plugin/skills/(fallback #1) after deletion, so loading is unaffected; loader comments and the software-factoryAGENTS.md/CLAUDE.mdskill-dir docs are updated to say so. Monorepo-root.agents/skills/is left as an empty fallback slot for future shared skills.Also clears
PENDING_BOXEL_REFERENCES:qunit-testing.mdshipped in v0.0.30, so the curated-references guard test was already failing on main; the pending-list test now handles the empty (normal) state.The remaining local factory skills are the process skills
software-factory-bootstrap,software-factory-operations,software-factory-scheduling. One unrelated pre-existing test flake remains (port-allocatordual-stack bind), untouched here.🤖 Generated with Claude Code