refactor(server): enforce server-only module boundaries with .server.ts convention#7
Merged
Merged
Conversation
…ts convention Rename server-side modules to the .server.ts convention so TanStack Start's importProtection can statically prevent them from leaking into the client bundle. - Rename jwt.ts → jwt.server.ts, mongoClient.ts → mongoClient.server.ts, getRepository.ts → getRepository.server.ts, and mongoRepository.ts → mongoRepository.server.ts - Enable importProtection in vite.config.ts targeting mongodb and the renamed server files; errors on client imports, skips test files - Update all import paths in auth.ts, serverFns.ts, and tests - Add pnpm-workspace.yaml with allowBuilds entries for native packages - Sync skill docs to document the .server.ts naming convention Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.server.tsconvention (jwt,mongoClient,getRepository,mongoRepository) so the file name itself signals that the module must never run in the browserimportProtectioninvite.config.tsto statically enforce the boundary: any client-side import ofmongodbor the renamed files now throws a build error (test files are excluded)auth.ts,serverFns.ts,jwt.test.ts) to the new pathspnpm-workspace.yamlwithallowBuildsentries for native packages (@parcel/watcher,@sentry/cli,@swc/core,esbuild,protobufjs,sharp).server.tsnaming conventionWhy
Without an enforced boundary, a developer can accidentally import
mongoClientor a JWT utility from a React component and ship Node.js-only code to the browser bundle. Splitting by name convention + build-time gating makes the mistake immediately visible rather than failing silently at runtime.Test plan
pnpm lintpasses (types + Biome)pnpm testpassespnpm buildcompletes without import-protection errorsmongoClient.server.tstriggers a build error