Fix use-after-free in IPC client connection lifetime management#6
Merged
jrosdahl merged 1 commit intoccache:mainfrom Apr 22, 2026
Merged
Fix use-after-free in IPC client connection lifetime management#6jrosdahl merged 1 commit intoccache:mainfrom
jrosdahl merged 1 commit intoccache:mainfrom
Conversation
Async storage callbacks captured the client by reference, causing use-after-free when the connection closed before the HTTP response arrived. Fix by switching ClientConnection to shared_ptr ownership: the server tracks clients in an unordered_map and callbacks capture a shared_ptr so the object stays alive until all in-flight requests complete. A disconnected flag prevents writing to a closed pipe.
Open
Member
|
Good catch, thanks! I'll make an additional robustness fix as a follow-up. |
jrosdahl
added a commit
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During our builds we did get coredumps of the storage helper. After some investigation it seems like those where caused by a heap memory corruption.
After analysis to me it seems like this could be the reason: