fix: avoid singleton mutation in NewFromJsonBytesContext

[davidlemme-usmobile]

Fixes #125

NewFromJsonBytesContext unmarshals JSON directly into the singleton pointers stored in CDEventsByUnversionedTypes. Since json.Unmarshal doesn't zero omitempty fields absent from the input, values from a previous call leak into subsequent calls for the same event type. This also causes a data race when called concurrently.

The fix uses reflect.New to create a fresh instance of the concrete type before unmarshalling, so the map entries are only used for type lookup and never mutated.

[afrittoli]

Thanks for catching and fixing this. The change looks good.

[afrittoli]

A pin was missing in CI: #127

[afrittoli]

@davidlemme-usmobile the PR looks good, but you'll need to rebase it so CI can succeed and then be merged.

[davidlemme-usmobile]

My pleasure. Rebased :)

[afrittoli]

It looks like your fix exposed a unit test that used to pass only because of the bug - the implicit_json_custom_data.json test fixture is missing some of the fields that are set in the expected result.
Would you mind fixing that as part of your PR as well?

[davidlemme-usmobile]

It looks like your fix exposed a unit test that used to pass only because of the bug - the implicit_json_custom_data.json test fixture is missing some of the fields that are set in the expected result. Would you mind fixing that as part of your PR as well?

Will do working on it shortly

[davidlemme-usmobile]

added the fix to the tests

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.14%. Comparing base (9a15314) to head (050efc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   85.12%   85.14%   +0.01%     
==========================================
  Files         149      149              
  Lines       13097    13098       +1     
==========================================
+ Hits        11149    11152       +3     
+ Misses       1631     1629       -2     
  Partials      317      317              

Files with missing lines	Coverage Δ
pkg/api/bindings.go	83.33% <100.00%> (+0.15%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[afrittoli]

Thank you!