fix: add ok check for CustomEventMapKey in NewFromJsonBytesContext#128
Merged
Conversation
The custom event path was doing a map lookup without checking the ok flag, leaving receiver as the zero value (nil) if CustomEventMapKey was absent. A subsequent reflect.TypeOf(receiver).Elem() would then panic. Add the same guard used for non-custom events. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 149 149
Lines 13095 13097 +2
=======================================
+ Hits 11147 11149 +2
Misses 1631 1631
Partials 317 317
🚀 New features to boost your workflow:
|
Add a test and fixture to exercise the new error returned when a custom event type is parsed with a cdeventsMap that does not contain CustomEventMapKey, ensuring the new branch is covered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewFromJsonBytesContextdid a map lookup onCustomEventMapKeywithout checking theokflagreceiverwould be the nil zero value forCDEventTypereflect.TypeOf(receiver).Elem()(orjson.Unmarshal) would then panicTest plan
go test -tags testonly ./pkg/api/)cdeventsMapwithoutCustomEventMapKeyreceives a custom event🤖 Generated with Claude Code