CELDEV-1304 - open celements package#541
Open
fpichler wants to merge 2 commits into
Open
Conversation
fpichler
force-pushed
the
CELDEV-1304-open-celements-package
branch
from
83d29b7 to
163a9ce
Compare
msladek
requested changes
Jun 13, 2026
| "not dead" | ||
| ] | ||
| } | ||
| } No newline at end of file |
| <arguments>run build</arguments> | ||
| </configuration> | ||
| </execution> | ||
| </executions> |
Member
There was a problem hiding this comment.
I don’t think celements-webapp should enforce ../celements-admin-frontend in its maven lifecycle. these are separate deployables, so they should be built as distinct stages with their own artifacts. if we want a product-level quality gate, we should introduce an overall root-level celements-web build/job that fails if either fails.
is there a specific reason this needs to happen inside the war/webapp maven lifecycle?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@open-celements/adminprivatetofalseexportsentry for./src/*so source modules can be imported from the package