add ceph-osd-crimson to noble builds for main/feature branches#2592
Draft
shraddhaag wants to merge 1 commit into
Draft
add ceph-osd-crimson to noble builds for main/feature branches#2592shraddhaag wants to merge 1 commit into
shraddhaag wants to merge 1 commit into
Conversation
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
shraddhaag
force-pushed
the
wip-shraddhaag-add-crimson-in-noble
branch
from
024e34d to
64f6272
Compare
Contributor
Author
|
I tried to test this out but I am running into permission errors Also, I'm not sure if |
Matan-B
reviewed
May 27, 2026
| // Build the ceph-osd-crimson package on noble for main/feature | ||
| // branches only (release lines reef/squid/tentacle excluded), | ||
| // matching the WITH_CRIMSON gate used for the builder image. | ||
| def withCrimson = !(env.BRANCH in ['tentacle', 'squid', 'reef']) |
Contributor
There was a problem hiding this comment.
I'm not sure this is the correct place to enable Crimson builds. This will result in every Noble/main build to be with Crimson. If that's the intent we would need to first verify that we are not breaking Noble builds for non-crimson usage.
In the past we had the dedicated flavor freedom to make such changes. Today, I think that the two options to verify a new distro would be:
- Pass specific build params when pushing a new build (https://github.com/ceph/ceph-build/tree/main/ceph-trigger-build#ceph-trigger-build - seems complicated for this purpose).
- The second option which I think would be easier to work with, is to enable crimson in
debian/controlfiles in the src - that way Jenkins could stay untouched to verify the build without affecting any other Noble builds.
| // matching the WITH_CRIMSON gate used for the builder image. | ||
| def withCrimson = !(env.BRANCH in ['tentacle', 'squid', 'reef']) | ||
| if ( withCrimson && env.DIST == "noble" ) { | ||
| deb_build_profiles = deb_build_profiles ? "${deb_build_profiles} pkg.ceph.crimson" : "pkg.ceph.crimson" |
Contributor
There was a problem hiding this comment.
I think this is out of Jenkins responsibility.
See how Crimson is enabled in rpm builds - ceph/ceph@08c334b.
Debian should follow the same logic once we are able to verify green builds (See debian/ceph-osd-crimson.postinst)
| axis { | ||
| name 'DIST' | ||
| notValues 'centos9', 'rocky10' | ||
| notValues 'centos9', 'rocky10', 'noble' |
Contributor
There was a problem hiding this comment.
nit, this is should be a seperate commit as it adds debug builds to noble (not related to the crimson change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit builds ceph-osd-crimson package for noble builds for every main and feature branch.
Testing as per: https://github.com/ceph/ceph-build?tab=readme-ov-file#testing-jjb-changes-by-hand-before-merging-to-main