s3tests: add tests for RestoreStatus in object listings#727
Merged
Conversation
14 tasks
| assert len(objs) == 1 | ||
| assert 'RestoreStatus' in objs[0] | ||
| assert objs[0]['RestoreStatus']['IsRestoreInProgress'] == False | ||
| assert 'RestoreExpiryDate' in objs[0]['RestoreStatus'] |
Contributor
There was a problem hiding this comment.
Could you please add a case for permanent restored objects too (that RestoreExpiryDate is not listed in the header) ?
Contributor
Author
There was a problem hiding this comment.
Done. Please let me know if this looks right.
Add tests to validate the x-amz-optional-object-attributes RestoreStatus support in listing responses. New tests: - test_list_objects_restore_status: validates RestoreStatus appears in list_objects and list_objects_v2 responses for temporarily restored objects, and is absent for normal objects or when the header is omitted - test_list_object_versions_restore_status: validates RestoreStatus appears for restored non-current versions while unrestored versions remain unaffected Signed-off-by: Matthew N. Heler <matthew.heler@hotmail.com>
6bee867 to
48494a1
Compare
soumyakoduri
approved these changes
May 19, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests to validate the x-amz-optional-object-attributes RestoreStatus support in listing responses.
New tests: