s3: align conditional write tests with If-None-Match '*' semantics#735
Open
peterxcli wants to merge 1 commit into
Open
s3: align conditional write tests with If-None-Match '*' semantics#735peterxcli wants to merge 1 commit into
peterxcli wants to merge 1 commit into
Conversation
Author
|
cc @cbodley |
Author
Author
Author
|
Please 🙏 |
Author
Author
|
@soumyakoduri Please could you also take a look at this🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the conditional write tests with S3 semantics for
If-None-Matchon write APIs.Changes
If-None-Matchcoverage limited to*for conditional put and multipart completionIf-None-MatchIf-Matchwith concrete ETags insteadWhy
Backends that correctly reject non-
*If-None-Matchvalues were being reported as failures by the test suite. This change narrows the tests to the supported conditionalwrite behavior and avoids false negatives in compatibility results.