Skip to content

test_s3: fix test_bucket_logging_request_id for newer botocore #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuvalif merged 1 commit into from
May 19, 2026
Merged

test_s3: fix test_bucket_logging_request_id for newer botocore #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions s3tests/functional/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15748,14 +15748,9 @@ def test_bucket_logging_request_id():
assert response['ResponseMetadata']['HTTPStatusCode'] == 200

# capture x-amz-request-id from the put_object response
request_id = None
def capture_request_id(**kwargs):
nonlocal request_id
request_id = kwargs['response']['ResponseMetadata']['HTTPHeaders'].get('x-amz-request-id')
client.meta.events.register('after-call.s3.PutObject', capture_request_id)

client.put_object(Bucket=src_bucket_name, Key=key, Body=randcontent())
assert request_id is not None, 'failed to capture x-amz-request-id from response'
response = client.put_object(Bucket=src_bucket_name, Key=key, Body=randcontent())
request_id = response['ResponseMetadata']['HTTPHeaders'].get('x-amz-request-id')
assert request_id is not None, 'failed to read x-amz-request-id from response headers'

_flush_logs(client, src_bucket_name)
response = client.list_objects_v2(Bucket=log_bucket_name)
Expand Down