Create missing ASN lookup database file#2704
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
The ASN lookup database updater rejected missing database files before it reached the code that creates the destination directory and writes the generated pyasn data. Allow a missing target file while still rejecting existing non-files and non-writable files. Add a mocked update-database regression test that writes a new database path and reloads the affected bot. Signed-off-by: BharatDeva <278575558+BharatDeva@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2689
Description
The ASN lookup updater currently checks that each configured database path already exists as a file before it downloads and parses the RouteViews data. That makes a first-time database update fail unless the target file is manually created first.
This change keeps the safety checks for paths that already exist, but allows a missing target file so the updater can create the parent directory and write the generated pyasn database as intended.
Tests
I ran the focused regression test and the ASN lookup test module under WSL:
The skipped tests are the existing exotic ASN lookup tests, which require the optional test flag/dependency path. The new update-database regression test ran successfully.