ENT-13073: Added linter errors for unknown promise types#30
Merged
olehermanse merged 1 commit intocfengine:mainfrom Mar 27, 2026
Merged
ENT-13073: Added linter errors for unknown promise types#30olehermanse merged 1 commit intocfengine:mainfrom
olehermanse merged 1 commit intocfengine:mainfrom
Conversation
SimonThalvorsen
force-pushed
the
ENT-13073
branch
4 times, most recently
from
8584d82 to
d3c5fe5
Compare
SimonThalvorsen
force-pushed
the
ENT-13073
branch
from
d3c5fe5 to
c87c3c9
Compare
Contributor
Author
|
@olehermanse I am unable to request reviewers |
olehermanse
requested changes
Mar 27, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good overall, let's get rid of the global mutable variables (consts are fine).
SimonThalvorsen
force-pushed
the
ENT-13073
branch
2 times, most recently
from
5976b3c to
905afe4
Compare
olehermanse
requested changes
Mar 27, 2026
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-13073
branch
from
905afe4 to
32a7c26
Compare
olehermanse
changed the title
olehermanse
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.