CFE-2852: dnf_group package module#3070
Merged
nickanderson merged 2 commits intocfengine:masterfrom Apr 10, 2026
Merged
Conversation
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
nickanderson
force-pushed
the
CFE-2852/master
branch
2 times, most recently
from
eb0f478 to
ccc4a74
Compare
nickanderson
changed the title
nickanderson
force-pushed
the
CFE-2852/master
branch
3 times, most recently
from
a6ff376 to
350572c
Compare
nickanderson
force-pushed
the
CFE-2852/master
branch
from
350572c to
7ea92df
Compare
nickanderson
force-pushed
the
CFE-2852/master
branch
3 times, most recently
from
10592c4 to
5cea8d5
Compare
Member
Author
|
I think that recursion failure is unrelated to this package module and instead related to that other file-separator change is that right @craigcomstock ? |
nickanderson
force-pushed
the
CFE-2852/master
branch
from
4aa392f to
5cea8d5
Compare
Contributor
Try to rebase with upstream/master @nickanderson |
larsewi
approved these changes
Apr 10, 2026
Member
Author
I have tried to rebase but it's still failing with the maximum recursion. notice: Q: ".../cf-agent" -f /": error: Maximum recursion level reached at '/var/lib/cfengine/inputs/cfe_internal/update/../../modules/packages/vendored' |
This module enables CFEngine to manage DNF/YUM package groups (e.g.,
"Development Tools", "System Tools") on RHEL/Rocky/AlmaLinux systems.
Key features:
- Install, upgrade, and remove package groups
- List installed groups and check for updates
- Configure group installation types (mandatory/default/optional packages)
- Supports DNF setopt-style configuration options
Example usage:
packages:
"system-tools"
policy => "present",
package_module => dnf_group;
"development"
policy => "present",
package_module => dnf_group,
options => { "group_package_types=optional", "install_weak_deps=false" }
version => "latest"; # Upgrade group packages
Ticket: CFE-2852
The filter() call in modules_presence needs to account for CFE-4623 behavior changes where findfiles() stopped suffixing directories with trailing slashes in CFEngine 3.24.0+. Prior to 3.24.0, findfiles() returned directory paths with trailing slashes (e.g., "/path/vendored/"). Starting in 3.24.0, the trailing slash was removed (e.g., "/path/vendored"). This broke the filter pattern that was designed to exclude the vendored subdirectory. The original fix (commit 3842469) unconditionally added $(const.dirsep) to the filter pattern. However, this breaks on versions where findfiles() still returns the trailing slash, causing maximum recursion errors during policy updates. This commit uses cf_version_between() and cf_version_at() to conditionally add the directory separator only for versions affected by CFE-4623: - 3.24.0 through 3.24.3 - 3.26.0 - 3.27.0 Versions outside this range use the original filter pattern without the additional separator. Related: - CFE-4623: findfiles() should suffix directories with a slash - Blog post: https://cfengine.com/blog/2025/change-in-behavior-findfiles/ - Original fix: commit 3842469 Ticket: CFE-2852 Changelog: Fixed maximum recursion errors in modules_presence for CFEngine versions unaffected by CFE-4623
nickanderson
force-pushed
the
CFE-2852/master
branch
from
597571f to
ac3d657
Compare
craigcomstock
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-2852