feat(security): enhance security features and logging in Dio#2525
Open
Sylvester-git wants to merge 1 commit into
Open
feat(security): enhance security features and logging in Dio#2525Sylvester-git wants to merge 1 commit into
Sylvester-git wants to merge 1 commit into
Conversation
- Add CertificatePinner for fingerprint-based certificate pinning. - Implement maxResponseSize to prevent memory exhaustion from large responses. - Warn developers about missing timeouts in requests. - Improve LogInterceptor to redact sensitive headers in logs. - Update SECURITY.md with secure usage guidelines.
AlexV525
requested changes
May 24, 2026
Member
AlexV525
left a comment
There was a problem hiding this comment.
Thanks for the purposal. But first, what is the motivation of these changes?
I've also have a couple of questions:
- What cannot be done with the current dio?
- The new SECURITY.md seems not only covering security concerns, and doesn't look like a standard security guide for the repo.
- Why the request touches
.gitignore?
We generally prefer precise, motivated, well-cared requests. Please reconsider if this is good to go. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)