Skip to content

feat: wrap AI agent config in evidence envelope#2870

Merged
jiparis merged 3 commits intochainloop-dev:mainfrom
jiparis:jiparis/pfm-4976
Mar 17, 2026
Merged

feat: wrap AI agent config in evidence envelope#2870
jiparis merged 3 commits intochainloop-dev:mainfrom
jiparis:jiparis/pfm-4976

Conversation

@jiparis
Copy link
Member

@jiparis jiparis commented Mar 17, 2026

Summary

  • Wraps CHAINLOOP_AI_AGENT_CONFIG material type in the standard custom schema envelope (chainloop.material.evidence.id, schema, data), aligning it with the pattern already used by CHAINLOOP_PR_INFO
  • Renames the internal Evidence struct to Data and introduces a new Evidence wrapper with EvidenceID and EvidenceSchemaURL constants
  • Updates the crafter to unwrap the envelope for schema validation while preserving raw JSON for strict field checking

Closes PFM-4976

@jiparis jiparis requested review from javirln and migmartri March 17, 2026 10:25
Use the standard custom schema structure for CHAINLOOP_AI_AGENT_CONFIG,
matching the pattern used by CHAINLOOP_PR_INFO. The payload is now
wrapped with chainloop.material.evidence.id, schema URL, and data fields.

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="pkg/attestation/crafter/materials/testdata/ai-agent-config-cursor.json">

<violation number="1" location="pkg/attestation/crafter/materials/testdata/ai-agent-config-cursor.json:13">
P3: The declared file size does not match the embedded base64 content. Update the fixture so `size` matches the decoded payload length.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Member

@javirln javirln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one comment

The schema version is now conveyed by the evidence envelope's schema
URL field, making the redundant schema_version field in the data
payload unnecessary.

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit 55d900f into chainloop-dev:main Mar 17, 2026
15 checks passed
@jiparis jiparis deleted the jiparis/pfm-4976 branch March 17, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants