feat: add gate support for policy groups#2924
Merged
matiasinsaurralde merged 6 commits intochainloop-dev:mainfrom Mar 24, 2026
Merged
feat: add gate support for policy groups#2924matiasinsaurralde merged 6 commits intochainloop-dev:mainfrom
matiasinsaurralde merged 6 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Vikram Vaswani <2571660+vvaswani@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 7 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Signed-off-by: Vikram Vaswani <2571660+vvaswani@users.noreply.github.com>
Signed-off-by: Vikram Vaswani <2571660+vvaswani@users.noreply.github.com>
Signed-off-by: Matías Insaurralde <matias@chainloop.dev>
Signed-off-by: Matías Insaurralde <matias@chainloop.dev>
The function overrides the policy gate with the group-level gate rather than inheriting a default, so applyGroupGate better reflects the actual behavior. Signed-off-by: Matías Insaurralde <matias@chainloop.dev>
matiasinsaurralde
approved these changes
Mar 24, 2026
Contributor
matiasinsaurralde
left a comment
matiasinsaurralde
left a comment
There was a problem hiding this comment.
Added some minor things - Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2773