Skip to content

fix(sast): fix codeql SAST warning #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiparis merged 3 commits into from
Mar 24, 2026
+9 −1
Merged

fix(sast): fix codeql SAST warning #2933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e58e969
fix codeql SAST warning
jiparis Mar 24, 2026
3774b55
fix: disable Secure cookie flag in development mode
jiparis Mar 24, 2026
7d54764
Revert "fix: disable Secure cookie flag in development mode"
jiparis Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/controlplane/internal/service/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,15 @@ func generateUserJWT(userID, passphrase string, expiration time.Duration) (strin
}

func setOauthCookie(w http.ResponseWriter, name, value string) {
http.SetCookie(w, &http.Cookie{Name: name, Value: value, Path: "/", Expires: time.Now().Add(10 * time.Minute)})
http.SetCookie(w, &http.Cookie{
Name: name,
Value: value,
Path: "/",
Expires: time.Now().Add(10 * time.Minute),
HttpOnly: true,
Copy link
Member

@migmartri migmartri Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might break local development, have you tried?

Copy link
Member Author

@jiparis jiparis Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both CLI and UI auth work perfectly.

Copy link
Member Author

@jiparis jiparis Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

@jiparis jiparis Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server response:
image

Copy link
Member Author

@jiparis jiparis Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And they are sent back after login:
image

Copy link
Member Author

@jiparis jiparis Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's strange, as I agree it should fail locally. I'll dig deeper into this.

Copy link
Member Author

@jiparis jiparis Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems that only Safari would break. Others consider "localhost" as secure: httpwg/http-extensions#2605

Secure: true,
SameSite: http.SameSiteLaxMode,
})
}

func generateAndLogDevUser(userUC *biz.UserUseCase, log *log.Helper, authConfig *conf.Auth) error {
Expand Down
Loading