Skip to content

feat(audit): emit OrgUserRemoved when admins remove members#3107

Merged
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:PFM-5928
May 12, 2026
Merged

feat(audit): emit OrgUserRemoved when admins remove members#3107
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:PFM-5928

Conversation

@Piskoo
Copy link
Copy Markdown
Collaborator

@Piskoo Piskoo commented May 12, 2026

Added a new OrgUserRemoved audit event and dispatched from MembershipUseCase.DeleteOther.

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/controlplane/pkg/auditor/events/organization.go">

<violation number="1" location="app/controlplane/pkg/auditor/events/organization.go:137">
P2: `OrgUserRemoved.ActionInfo()` should also validate `RemovedUserEmail`; otherwise the new audit event can be recorded with missing subject identity and an incomplete description.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread app/controlplane/pkg/auditor/events/organization.go Outdated
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo requested review from jiparis and migmartri May 12, 2026 09:45
@Piskoo Piskoo marked this pull request as ready for review May 12, 2026 09:45
@jiparis
Copy link
Copy Markdown
Member

jiparis commented May 12, 2026

thanks!

@Piskoo Piskoo merged commit 46339ce into chainloop-dev:main May 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants