feat(filepicker): add support for abstracted filesystem io/fs.FS#759
Closed
dolmen wants to merge 1 commit into
Closed
feat(filepicker): add support for abstracted filesystem io/fs.FS#759dolmen wants to merge 1 commit into
dolmen wants to merge 1 commit into
Conversation
dolmen
changed the title
dolmen
force-pushed
the
filepicker-add-support-for-fs.FS
branch
from
5646902 to
a0d6cf8
Compare
dolmen
added a commit
to dolmen-go/iofs-shell
that referenced
this pull request
Apr 1, 2025
This requires so far my fork of bubbles/filepicker that allows to browse an io/fs.FS (see charmbracelet/bubbles#759).
Author
|
Cc: @maaslalani (filepicker original author) for review |
Author
|
Cc: @meowgorithm for review |
This was referenced Oct 15, 2025
Add an optional io/fs.FS to filepicker's model to allow to browse an abstracted filesystem instead of the full filesystem exposed by the 'os' package. Note that Go 1.25 will add io/fs.ReadLink, but we can't use it yet. So we implement symlink resolution here. By the way, references to os types and constants which are aliases to same symbols in io/fs are replaced: os.Mode*, os.DirEntry.
dolmen
force-pushed
the
filepicker-add-support-for-fs.FS
branch
from
a0d6cf8 to
2d5bdfa
Compare
dolmen
added a commit
to dolmen-go/bubbles.fork
that referenced
this pull request
Apr 13, 2026
Add an optional io/fs.FS to filepicker's model to allow to browse an abstracted filesystem instead of the full filesystem exposed by the 'os' package. To resolve symlinks we use io/fs.ReadLink introduced with Go 1.25, but fallback to an internal implementation if the FS doesn't implement it. By the way, references to os types and constants (which nowadays are aliases to same symbols in io/fs) are replaced: os.Mode*, os.DirEntry. Fixes charmbracelet#815. Replaces charmbracelet#759.
dolmen
added a commit
to dolmen-go/bubbles.fork
that referenced
this pull request
Apr 13, 2026
Add an optional io/fs.FS to filepicker's model to allow to browse an abstracted filesystem instead of the full filesystem exposed by the 'os' package. To resolve symlinks we use io/fs.ReadLink introduced with Go 1.25, but fallback to an internal implementation if the FS doesn't implement it. By the way, references to os types and constants (which nowadays are aliases to same symbols in io/fs) are replaced: os.Mode*, os.DirEntry. Fixes charmbracelet#815. Replaces charmbracelet#759.
2 tasks
Author
|
Closing because replaced by #954 upgraded to v2 API. |
dolmen
added a commit
to dolmen-go/bubbles.fork
that referenced
this pull request
May 11, 2026
Add an optional io/fs.FS to filepicker's model to allow to browse an abstracted filesystem instead of the full filesystem exposed by the 'os' package. To resolve symlinks we use io/fs.ReadLink introduced with Go 1.25, but fallback to an internal implementation if the FS doesn't implement it. By the way, references to os types and constants (which nowadays are aliases to same symbols in io/fs) are replaced: os.Mode*, os.DirEntry. Fixes charmbracelet#815. Replaces charmbracelet#759.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
io/fs.FStofilepicker's model to allow to browse an abstracted filesystem as an alternative to the full filesystem exposed by theospackage.The filepicker API is extended (and generalized thanks to io/fs.FS), without any breaking change.
This allows for example to browse limited a subdirectory by using
os.Root(go1.24+):Note that Go 1.25 will add
io/fs.ReadLink, but we can't use it yet. So we implement symlink resolution here.By the way, references to
ostypes and constants which are aliases to same symbols inio/fsare replaced:os.Mode*,os.DirEntry.Example
See package github.com/dolmen-go/iofs-shell.
Runnable example: