fix(textinput): show full placeholder when Width is not set#988
Open
troclaux wants to merge 1 commit into
Open
fix(textinput): show full placeholder when Width is not set#988troclaux wants to merge 1 commit into
troclaux wants to merge 1 commit into
Conversation
When Width is 0 (default), make([]rune, m.Width()+1) created a 1-element slice causing copy to only transfer the first rune. The subsequent check m.Width() < 1 && len(p) <= 1 then triggered an early return, rendering only the first character of the placeholder. Fix by allocating max(m.Width()+1, len(placeholderRunes)) so the full placeholder always fits, and update the early-return condition to use len(placeholderRunes) instead of len(p). Fixes charmbracelet#779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #779: when
Widthis0(the default), only the first character of the placeholder was displayed.Root cause
placeholderViewallocatedmake([]rune, m.Width()+1)— a 1-element slice whenWidthis 0. Aftercopy, only one rune was transferred. The subsequent guardm.Width() < 1 && len(p) <= 1then triggered an early return, rendering only that single character.Changes
textinput.go: allocatemax(m.Width()+1, len(placeholderRunes))so the full placeholder always fits; update the early-return condition to checklen(placeholderRunes) <= 1instead oflen(p) <= 1.Testing
TestPlaceholderFullRenderWithoutWidthverifies the full placeholder appears whenWidthis not set.Fixes #779