Skip to content

fix(help): style full help column padding#989

Open
Yongcheng123 wants to merge 1 commit into
charmbracelet:mainfrom
Yongcheng123:fix/full-help-separator-padding
Open

fix(help): style full help column padding#989
Yongcheng123 wants to merge 1 commit into
charmbracelet:mainfrom
Yongcheng123:fix/full-help-separator-padding

Conversation

@Yongcheng123
Copy link
Copy Markdown

Summary

  • render the full-help separator as a multiline block so separator styling also covers inter-row padding
  • size the separator block from the rendered row count after disabled bindings are filtered out
  • add regression tests for styled padding and disabled bindings

Testing

  • go test ./...
  • go vet ./...

Closes #572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lack of Style Options for Spaces in Full Help View Columns

1 participant