Fix bottom navigation safe-area inset on button navigation#2
Open
DisYaBoiRalph wants to merge 1 commit into
Open
Fix bottom navigation safe-area inset on button navigation#2DisYaBoiRalph wants to merge 1 commit into
DisYaBoiRalph wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the extra bottom "chin" gap seen on devices using 3-button navigation. (Yes, I'm used to nav buttons)
Instead of applying bottom system-bar inset to the entire root container, the app now applies it directly to
BottomNavigationView.What changed
MainActivitywindow-insets handling.bottom_navigation.bottomNavigationreference for item selection listener.Why
Applying bottom inset to the whole root layout can create extra visual space above the navigation area on button-navigation devices. Applying that inset to the bottom nav itself keeps layout behavior correct across gesture and button navigation modes.
Scope
Screenshots
Before
After