Skip to content

fix: close decision bucket findings#1202

Merged
chhoumann merged 1 commit into
masterfrom
scorecard/16-decision-bucket
May 14, 2026
Merged

fix: close decision bucket findings#1202
chhoumann merged 1 commit into
masterfrom
scorecard/16-decision-bucket

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

@chhoumann chhoumann commented May 13, 2026

Document and encode the final decision-bucket remediations.

This handles findings that required product judgment rather than mechanical cleanup: command label text is centralized while preserving command IDs, and utility tests cover the intentionally retained user-script/eval behavior and related waiver decisions.

Review focus:

  • Command label changes versus stable command IDs.
  • User-script/eval decision coverage in utilityObsidian.test.ts.
  • Whether the centralized label helper matches expected UI wording.

Stack position: 16/17, based on scorecard/15-build-release-hygiene.

Validated as part of the completed scorecard mission with bun run build-with-lint, bun run test, bun run build, bun run test:e2e, and Obsidian dev vault reload/smoke checks.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a6b2baa-850f-44e0-8c44-f14371601636

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch scorecard/16-decision-bucket

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chhoumann chhoumann marked this pull request as ready for review May 13, 2026 15:30
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 13, 2026

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1eb845
Status:⚡️  Build in progress...

View logs

@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 5eab0c1 to c4112b5 Compare May 14, 2026 09:35
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch 2 times, most recently from 3cec176 to fbb6557 Compare May 14, 2026 09:54
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch 2 times, most recently from aa3f2b7 to 964ff2f Compare May 14, 2026 10:20
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from fbb6557 to bb391b3 Compare May 14, 2026 10:20
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 964ff2f to 1392394 Compare May 14, 2026 10:28
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from bb391b3 to b3618f3 Compare May 14, 2026 10:28
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 1392394 to 0786e1a Compare May 14, 2026 10:45
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from b3618f3 to 255c2ad Compare May 14, 2026 10:45
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 0786e1a to c39fe67 Compare May 14, 2026 10:49
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 255c2ad to 0340967 Compare May 14, 2026 10:50
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from c39fe67 to 4a5f472 Compare May 14, 2026 10:51
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 0340967 to 795ad92 Compare May 14, 2026 10:51
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 4a5f472 to fd4ece4 Compare May 14, 2026 10:52
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 795ad92 to e31d421 Compare May 14, 2026 10:52
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from fd4ece4 to a1f83f9 Compare May 14, 2026 10:53
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from e31d421 to 2fddda9 Compare May 14, 2026 10:53
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from a1f83f9 to ccd77c8 Compare May 14, 2026 10:54
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 2fddda9 to 24ddb96 Compare May 14, 2026 10:54
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from ccd77c8 to 6a75b43 Compare May 14, 2026 10:54
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 24ddb96 to ecdd896 Compare May 14, 2026 10:54
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 6a75b43 to 46bf3f2 Compare May 14, 2026 10:55
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from ecdd896 to 9f3abac Compare May 14, 2026 10:55
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 46bf3f2 to fa47a89 Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 9f3abac to a871916 Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from fa47a89 to d835f8f Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from a871916 to 489c0fb Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from d835f8f to 8636b5f Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 489c0fb to a01d773 Compare May 14, 2026 10:56
@chhoumann chhoumann force-pushed the scorecard/15-build-release-hygiene branch from 8636b5f to ee370e5 Compare May 14, 2026 10:57
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from a01d773 to 1b1dfce Compare May 14, 2026 10:57
@chhoumann chhoumann force-pushed the scorecard/16-decision-bucket branch from 1b1dfce to c1eb845 Compare May 14, 2026 10:57
@chhoumann chhoumann changed the base branch from scorecard/15-build-release-hygiene to master May 14, 2026 10:59
@chhoumann chhoumann merged commit cf9d8dd into master May 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant