fix: close decision bucket findings#1202
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5eab0c1 to
c4112b5
Compare
3cec176 to
fbb6557
Compare
aa3f2b7 to
964ff2f
Compare
fbb6557 to
bb391b3
Compare
964ff2f to
1392394
Compare
bb391b3 to
b3618f3
Compare
1392394 to
0786e1a
Compare
b3618f3 to
255c2ad
Compare
0786e1a to
c39fe67
Compare
255c2ad to
0340967
Compare
c39fe67 to
4a5f472
Compare
0340967 to
795ad92
Compare
4a5f472 to
fd4ece4
Compare
795ad92 to
e31d421
Compare
fd4ece4 to
a1f83f9
Compare
e31d421 to
2fddda9
Compare
a1f83f9 to
ccd77c8
Compare
2fddda9 to
24ddb96
Compare
ccd77c8 to
6a75b43
Compare
24ddb96 to
ecdd896
Compare
6a75b43 to
46bf3f2
Compare
ecdd896 to
9f3abac
Compare
46bf3f2 to
fa47a89
Compare
9f3abac to
a871916
Compare
fa47a89 to
d835f8f
Compare
a871916 to
489c0fb
Compare
d835f8f to
8636b5f
Compare
489c0fb to
a01d773
Compare
8636b5f to
ee370e5
Compare
a01d773 to
1b1dfce
Compare
1b1dfce to
c1eb845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document and encode the final decision-bucket remediations.
This handles findings that required product judgment rather than mechanical cleanup: command label text is centralized while preserving command IDs, and utility tests cover the intentionally retained user-script/eval behavior and related waiver decisions.
Review focus:
utilityObsidian.test.ts.Stack position: 16/17, based on
scorecard/15-build-release-hygiene.Validated as part of the completed scorecard mission with
bun run build-with-lint,bun run test,bun run build,bun run test:e2e, and Obsidiandevvault reload/smoke checks.