test: add final scorecard composed e2e

[chhoumann]

Add final composed e2e coverage for the completed scorecard remediation stack.

This final stack PR adds Obsidian-backed composed-flow coverage that exercises the remediated areas together rather than only as isolated unit tests. It is intended as the acceptance layer for the preceding remediation PRs.

Review focus:

• scorecard-composed-flows.test.ts coverage of macro/template/capture/multi flows.
• Whether the e2e assertions reflect realistic QuickAdd usage in the dev vault.
• Any fragility in the composed Obsidian CLI-backed flow setup.

Stack position: 17/17, based on scorecard/16-decision-bucket.

Validated as part of the completed scorecard mission with bun run build-with-lint, bun run test, bun run build, bun run test:e2e, and Obsidian dev vault reload/smoke checks.

Summary by CodeRabbit

• Tests
  • Added comprehensive end-to-end test suite for scorecard template and capture workflows, including macro composition and multi-choice routing scenarios with automated failure artifact capture for improved debugging and test reliability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c248e6e-622f-415a-a556-a389e37c1bca

📥 Commits

Reviewing files that changed from the base of the PR and between cf9d8dd and 0b36cb6.

📒 Files selected for processing (1)

• tests/e2e/scorecard-composed-flows.test.ts

---

📝 Walkthrough

Walkthrough

Adds a Vitest E2E test module that sets up vault-run locking and a sandbox, provides QuickAdd choice builders and execution/teardown helpers, patches QuickAdd with composed macro and routed multi-child choices, and runs two acceptance tests validating template output and routed multi-capture behavior.

Changes

Scorecard Composition E2E Tests

Layer / File(s)	Summary
Module setup and lifecycle management tests/e2e/scorecard-composed-flows.test.ts	Module imports vitest and Obsidian e2e helpers, defines vault/plugin/test constants and shared wait options, and provides module-level beforeAll/afterAll that acquire/publish the vault run lock, initialize the sandbox API, and perform resilient teardown.
Test utilities and choice helpers tests/e2e/scorecard-composed-flows.test.ts	Adds builder functions for QuickAdd Template, Capture, Macro, and Multi choices, a helper to remove prior test choices by __qa-scorecard- prefix, runChoice to execute choices, and runTeardownStep to aggregate teardown errors.
Suite-level setup and per-test failure handling tests/e2e/scorecard-composed-flows.test.ts	Suite beforeAll writes scorecard-template.md, deletes previous sandbox outputs/targets, patches QuickAdd plugin data with the composed macro (template → capture) and routed multi-child capture, reloads QuickAdd, and beforeEach captures failure artifacts on test failures.
Acceptance tests for composed flows tests/e2e/scorecard-composed-flows.test.ts	First test runs the composed macro and asserts created template-output and capture-target files with expected bodies. Second test verifies routing state via quickadd:list, runs the routed multi-capture child, and asserts the capture target contains the expected multi child body.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐇 A scorecard test hops into view,
Composing choices, old and new,
Locks held tight while templates grow,
Macro runs and routed paths flow.
Two tests confirm the outputs true.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch scorecard/17-final-scorecard-e2e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07fcac7e48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cloudflare-workers-and-pages]

Deploying quickadd with    Cloudflare Pages

Latest commit:	0b36cb6
Status:	⚡️  Build in progress...

View logs