Skip to content

refactor: flatten template choice executor#1206

Closed
chhoumann wants to merge 2 commits into
engine-flat/02-formatter-template-servicesfrom
engine-flat/03-template-choice
Closed

refactor: flatten template choice executor#1206
chhoumann wants to merge 2 commits into
engine-flat/02-formatter-template-servicesfrom
engine-flat/03-template-choice

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

Summary

  • Converts TemplateChoiceEngine into a flat executor composed from explicit services/evaluators.
  • Preserves template file creation, append/overwrite, folder selection, and formatter behavior.
  • Adds validation coverage for rejected/missing folder selections.

Stack

  1. engine-flat/01-vault-frontmatter-services
  2. engine-flat/02-formatter-template-services
  3. This PR
  4. engine-flat/04-capture-choice
  5. engine-flat/05-macro-cutover

Validation

  • bun run lint
  • bun run test
  • bun run build
  • Obsidian dev vault plugin reload and e2e validation

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eaafadf4-c65e-446c-b5ba-152d1cfe87a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch engine-flat/03-template-choice

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 15, 2026

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9766b9
Status: ✅  Deploy successful!
Preview URL: https://0778b374.quickadd.pages.dev
Branch Preview URL: https://engine-flat-03-template-choi.quickadd.pages.dev

View logs

@chhoumann chhoumann force-pushed the engine-flat/03-template-choice branch from f1bc041 to b9766b9 Compare May 16, 2026 15:35
@chhoumann chhoumann force-pushed the engine-flat/02-formatter-template-services branch from c338da3 to 59ad913 Compare May 16, 2026 15:35
@chhoumann
Copy link
Copy Markdown
Owner Author

Closing this stack after deciding not to continue with this refactor direction.

@chhoumann chhoumann closed this May 16, 2026
@chhoumann chhoumann deleted the engine-flat/03-template-choice branch May 16, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant