Skip to content

refactor: flatten macro runtime and remove base engines#1208

Open
chhoumann wants to merge 7 commits into
engine-flat/04-capture-choicefrom
engine-flat/05-macro-cutover
Open

refactor: flatten macro runtime and remove base engines#1208
chhoumann wants to merge 7 commits into
engine-flat/04-capture-choicefrom
engine-flat/05-macro-cutover

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

Summary

  • Extracts macro execution context and command running into flat, explicit runtime components.
  • Routes inline JavaScript and macro/template token evaluation through compatibility-preserving evaluator seams.
  • Deletes obsolete inheritance-based engine files and refreshes architecture notes after the cutover.

Stack

  1. engine-flat/01-vault-frontmatter-services
  2. engine-flat/02-formatter-template-services
  3. engine-flat/03-template-choice
  4. engine-flat/04-capture-choice
  5. This PR

Validation

  • bun run lint
  • bun run test
  • bun run build
  • Obsidian dev vault plugin reload and e2e validation

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 35b05e5b-15ac-4dc1-8cbd-23ed2a9a7ec5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch engine-flat/05-macro-cutover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 15, 2026

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: db6915d
Status: ✅  Deploy successful!
Preview URL: https://477507fe.quickadd.pages.dev
Branch Preview URL: https://engine-flat-05-macro-cutover.quickadd.pages.dev

View logs

@chhoumann chhoumann force-pushed the engine-flat/04-capture-choice branch from 375bc8a to fb2799c Compare May 16, 2026 15:35
@chhoumann chhoumann force-pushed the engine-flat/05-macro-cutover branch from 424135d to db6915d Compare May 16, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant