refactor: embed skills/agents via include_dir, remove setup binary#43
Closed
chinkan wants to merge 3 commits into
Closed
refactor: embed skills/agents via include_dir, remove setup binary#43chinkan wants to merge 3 commits into
chinkan wants to merge 3 commits into
Conversation
- Remove two-layer SkillRegistry (instance + bundled with SkillSource) - Embed skills/ and agents/ at compile time via include_dir crate - Simplify SkillRegistry to single-layer skills map - Remove src/bin/setup.rs and setup.sh (use rustfox --setup instead) - Fix web wizard JS to only emit [skills]/[agents] when user provides values - Fix /update-skills to backup modified files before overwriting - Remove bundled_directory from SkillsConfig/AgentsConfig - Fix all reload handlers to use full registry replacement
- Extract format_listed_section() shared preamble helper used by both build_context() (skills) and the new Available Agents section builder. - Rename build_subagent_context -> build_subagent_lines for accuracy. - Extract format_available_agents_section() pure function with 5 unit tests. - Remove redundant early return in build_agents_context(). - Update invoke_agent tool description to reference unified section. - Fix stale invoke_subagent references in news-fetcher/problem-solver skills.
Owner
Author
|
Merged into #42 — all changes have been incorporated into the send-file-from-sandbox branch. |
Owner
Author
|
Superseded by #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
rustfox --setupinstead[skills]/[agents]sections when user provides non-empty values