Skip to content

Upgrade eslint and fix formatting on files#285

Merged
AriPerkkio merged 20 commits intomainfrom
norbert/upgrade-eslint
Mar 30, 2026
Merged

Upgrade eslint and fix formatting on files#285
AriPerkkio merged 20 commits intomainfrom
norbert/upgrade-eslint

Conversation

@ndelangen
Copy link
Copy Markdown
Member

Issue: #282

What Changed

As requested, I've split the work to upgrade eslint to this separate PR, for easier review and future tracability

How to test

You check check out this branch locally, and run both eslint and prettier to success.

eslint does have a few warnings about usage of any, but I think it's a good indicator to stay away from that, as it's type-unsafe.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2026

🦋 Changeset detected

Latest commit: e7971a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chromatic-com/playwright Patch
@chromatic-com/cypress Patch
@chromatic-com/shared-e2e Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ndelangen ndelangen changed the title run prettier over codebase Upgrade eslint and fix formatting on files Mar 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (d339edd) to head (e7971a0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          14       14           
  Lines         400      400           
  Branches       68       68           
=======================================
  Hits          383      383           
  Misses         16       16           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ndelangen
Copy link
Copy Markdown
Member Author

@skitterm this does mean that cypress cannot work right now. As the version isn't compatible with typescript config settings / the new version.

Comment thread packages/shared/package.json Outdated
Comment thread packages/shared/tsconfig.json Outdated
Comment thread .gitignore Outdated
Comment thread tsconfig.json Outdated
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
@skitterm
Copy link
Copy Markdown
Member

skitterm commented Mar 5, 2026

@skitterm this does mean that cypress cannot work right now. As the version isn't compatible with typescript config settings / the new version.

@ndelangen just to clarify, you mean that once #286 is merged into this branch Cypress will work again, right? If so, that's fine. (All the checks in #286 worked, so I assume the issue here is that we have newer TS configs here but still the 13.x Cypress version.)

Copy link
Copy Markdown
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen thanks for adding the any warning!

Comment thread packages/playwright/package.json
Comment thread .changeset/handle-core-berries.md
Comment thread packages/shared/package.json Outdated
@AriPerkkio AriPerkkio merged commit ea271c9 into main Mar 30, 2026
9 checks passed
@AriPerkkio AriPerkkio deleted the norbert/upgrade-eslint branch March 30, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants