Upgrade eslint and fix formatting on files#285
Conversation
🦋 Changeset detectedLatest commit: e7971a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eslint and fix formatting on files
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 14 14
Lines 400 400
Branches 68 68
=======================================
Hits 383 383
Misses 16 16
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@skitterm this does mean that |
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
@ndelangen just to clarify, you mean that once #286 is merged into this branch Cypress will work again, right? If so, that's fine. (All the checks in #286 worked, so I assume the issue here is that we have newer TS configs here but still the |
skitterm
left a comment
There was a problem hiding this comment.
@ndelangen thanks for adding the any warning!
Upgrade cypress to latest
Remove minification & sourcemap generation
Issue: #282
What Changed
As requested, I've split the work to upgrade eslint to this separate PR, for easier review and future tracability
How to test
You check check out this branch locally, and run both eslint and prettier to success.
eslint does have a few warnings about usage of
any, but I think it's a good indicator to stay away from that, as it's type-unsafe.