feat: bundle uuid into stack package and expose schema builder#451
feat: bundle uuid into stack package and expose schema builder#451calvinbrewer wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 1c2fdbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR introduces two updates to ChangesStack Release: columnBuilders API & CJS uuid Fix
Possibly related PRs
Suggested reviewers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "@cipherstash/stack": minor | ||
| --- | ||
|
|
||
| Fix CJS consumers crashing with `Must use import to load ES Module: .../uuid/dist-node/index.js`. The `uuid` package is pure ESM and has no CJS entry point, so the CJS build of `@cipherstash/stack` could not `require()` it at runtime. `uuid` is now bundled into the CJS output (the ESM build is unchanged). |
There was a problem hiding this comment.
Can we add something to tests/CI to validate this and prevent regressions?
coderdan
left a comment
There was a problem hiding this comment.
I'd prefer to add some test or verification before approving.
Summary by CodeRabbit
Bug Fixes
New Features