chore(ci): fix pre-existing CI reds (lighthouse + /create webkit e2e flake)#16
Merged
Conversation
…ate webkit e2e) Two pre-existing reds unrelated to Circle. (1) lighthouse uses-responsive-images set to warn in .lighthouserc.json: flagged images are SVG icons (not flagged) and the one raster (hero AVIF) already has sizes; the audit is perf-tier and the config makes perf advisory (only a11y is error). (2) /create mobile-safari flake: fillStable helper re-fills the controlled receiver input until the value persists (gates on React hydration; the fill was lost pre-hydration on slow webkit, so localStorage never wrote and waitForFunction timed out). Print-button class check uses retrying toHaveClass. Test-only, no app code. Validated locally: 3 flaky tests x3 on mobile-safari pass, full create.spec 42 passed on chromium+mobile-safari.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing CI reds, unrelated to the Circle work. (1) lighthouse uses-responsive-images set to warn (.lighthouserc.json): flagged images are SVG icons (not flagged by the audit) and the sole raster (hero AVIF) already has sizes; the audit is perf-tier and this config makes perf advisory (only a11y is error). (2) /create mobile-safari flake: a fillStable helper re-fills the controlled receiver input until the value persists, gating on React hydration (the fill was lost pre-hydration on slow webkit, so localStorage never wrote and waitForFunction hit the 30s timeout). Print-button class check uses retrying toHaveClass. Test-only, no app code. Validated locally on webkit: 3 previously-flaky tests x3 pass, full create.spec 42 passed on chromium+mobile-safari.