Handle CircleCI jobs without the "dependencies" property in the workflow notifier.#1408
Merged
Merged
Conversation
psmyrek
approved these changes
Jun 30, 2026
Member
|
From the issue DoD's:
Was this considered? And if so, why did you reject implementing it? |
Member
Author
Yes, but I generally avoid adding logic for blindly retrying the code because it can mask real issues. It would be overkill here because the fix for the actual root cause was small enough, and such errors are so uncommon. IMO, retry logic should only be added as a last resort, when the provided code is fundamentally flawed and cannot be fixed or the expense is too great to justify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Handle CircleCI jobs without the
dependenciesproperty in the workflow notifier. The CircleCI API may return job objects without that property, which causedprocessJobStatuses()to throw. Such jobs are now treated as jobs with no dependencies.📌 Related issues
💡 Additional information
The fix is a minimal optional-chaining guard (
!job.dependencies?.length); the later dependency lookup is already gated behind that check. Added test coverage for jobs with a missingdependenciesproperty.