-
Notifications
You must be signed in to change notification settings - Fork 453
docs(repo): Add additional typedoc outputs #8483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ac42c39
602b8f1
1327d5a
d353fbd
a1330a6
708e920
50c858f
4afcb10
34e9924
afe2724
ec4e40f
86427f3
1e27689
22fe185
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@clerk/backend": patch | ||
| "@clerk/shared": patch | ||
| --- | ||
|
|
||
| Fix OAuth consent component and hook related types. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,12 +14,6 @@ const HOOK_NAME = 'useOAuthConsent'; | |
| * (`GET /me/oauth/consent/{oauthClientId}`). Ensure the user is authenticated before relying on this hook | ||
| * (for example, redirect to sign-in on your custom consent route). | ||
| * | ||
| * The hook is a pure data fetcher: it takes an explicit `oauthClientId` and optional `scope` and | ||
| * issues the fetch when both the user is signed in and `oauthClientId` is non-empty. The query is | ||
| * disabled when `oauthClientId` is empty or omitted. | ||
| * | ||
| * @internal | ||
| * | ||
| * @example | ||
| * ```tsx | ||
| * import { useOAuthConsent } from '@clerk/react/internal' | ||
|
|
@@ -30,7 +24,7 @@ const HOOK_NAME = 'useOAuthConsent'; | |
| * }) | ||
| * ``` | ||
| */ | ||
| export function useOAuthConsent(params: UseOAuthConsentParams = {}): UseOAuthConsentReturn { | ||
| export function useOAuthConsent(params: UseOAuthConsentParams): UseOAuthConsentReturn { | ||
| useAssertWrappedByClerkProvider(HOOK_NAME); | ||
|
|
||
| const { oauthClientId: oauthClientIdParam, scope, keepPreviousData = true, enabled = true } = params; | ||
|
Comment on lines
+27
to
30
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep Removing the default object turns Suggested fix export function useOAuthConsent(params: UseOAuthConsentParams): UseOAuthConsentReturn {
useAssertWrappedByClerkProvider(HOOK_NAME);
- const { oauthClientId: oauthClientIdParam, scope, keepPreviousData = true, enabled = true } = params;
+ const {
+ oauthClientId: oauthClientIdParam,
+ scope,
+ keepPreviousData = true,
+ enabled = true,
+ } = params ?? ({} as UseOAuthConsentParams);
const clerk = useClerkInstanceContext();
const user = useUserBase();🤖 Prompt for AI Agents |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammar: hyphenate compound modifier.
"hook related types" should be "hook-related types" (hyphenated compound modifier).
📝 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents