Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-masks-warn-google-plugin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/expo": patch
---

Clarify the native Google Sign-In migration warning to mention the required Expo config plugin.
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('useSignInWithGoogle', () => {

expect(consoleWarnSpy).toHaveBeenCalledTimes(1);
expect(consoleWarnSpy).toHaveBeenCalledWith(
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin. The @clerk/expo/google import path will continue to work.',
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin and adding its Expo config plugin. The @clerk/expo/google import path will continue to work.',
);
} finally {
consoleWarnSpy.mockRestore();
Expand Down
2 changes: 1 addition & 1 deletion packages/expo/src/hooks/useSignInWithGoogle.android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type {
* - No additional dependencies required
*
* In the next major version, apps using native Google Sign-In will need to install
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
*
* @example
* ```tsx
Expand Down
2 changes: 1 addition & 1 deletion packages/expo/src/hooks/useSignInWithGoogle.ios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type {
* - No additional dependencies required
*
* In the next major version, apps using native Google Sign-In will need to install
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
*
* @example
* ```tsx
Expand Down
2 changes: 1 addition & 1 deletion packages/expo/src/hooks/useSignInWithGoogle.shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function warnAboutGoogleSignInPackageMigration() {

hasWarnedAboutGoogleSignInPackage = true;
console.warn(
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin. The @clerk/expo/google import path will continue to work.',
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin and adding its Expo config plugin. The @clerk/expo/google import path will continue to work.',
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/expo/src/hooks/useSignInWithGoogle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type StartGoogleAuthenticationFlowReturnType = {
* For web platforms, use the OAuth-based Google Sign-In flow instead via useSSO.
*
* In the next major version, apps using native Google Sign-In will need to install
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
*
* @example
* ```tsx
Expand Down
Loading