TypeScript HTTP handlers - Module Bindings#4980
Conversation
…http_shared to avoid circular references
gefjon
left a comment
There was a problem hiding this comment.
In crates/smoketests/tests/smoketests/http_routes.rs, can you remove the typescript_http_routes_end_to_end test, and instead add a TypeScript version of each of the Rust module smoketests in that file? Otherwise this all looks good to my undtrained eye.
Digging back into the smoketests pointed out I missed updating the docs as well; both are cleaned up now. |
gefjon
left a comment
There was a problem hiding this comment.
Smoketests and docs both look great! One minor request to simplify the smoketest code. Let's try to get @coolreader18 to review this as they're more fluent in TypeScript and have a better sense of how this will integrate with our current APIs than me.
Description of Changes
Cleaning up the TypeScript HTTP handler module bindings on top of the V8 host/module work from #4931.
API and ABI breaking changes
Cleaning up the API layer:
Expected complexity level and risk
2 - I needed to move code out of http_internal.ts to have it shareable for http_handler.ts adding more churn than I'd like.
Testing