C# HTTP handlers - Module Bindings#5024
Open
JasonAtClockwork wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adding C# HTTP handlers based on #4636
[SpacetimeDB.HttpHandler],[SpacetimeDB.HttpRouter]Handlers.*tokens to avoid raw stringsAPI and ABI breaking changes
Adds new APIs for the HTTP handler and should not be breaking
Expected complexity level and risk
3 - this hit the binding, module registration, and had a decent refactor for ProcedureContext
Testing
crates/smoketests/tests/smoketests/http_routes.rswith C# mirrors of the Rust HTTProute tests
I also did some manual testing with a throw away project, and will be adding to the
module-testafter all languages are caught up on HTTP handlers.