Clarify CLI login HTTP errors#5518
Merged
Merged
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
bfops
reviewed
Jul 10, 2026
clockwork-labs-bot
force-pushed
the
bot/login-http-error
branch
from
518b1ca to
71b761e
Compare
clockwork-labs-bot
force-pushed
the
bot/login-http-error
branch
from
71b761e to
929806d
Compare
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Jul 10, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improve
spacetime loginerror clarity when login/auth endpoints return a non-success HTTP status.Previously, the CLI attempted to decode JSON immediately, so a bad
--auth-hostthat returned HTML/plaintext produced a generic JSON decoding error likeexpected value at line 1 column 1. The login flow now callserror_for_status()before JSON decoding on the web-auth login token request, login status polling, and SpacetimeDB token exchange paths.API and ABI breaking changes
None.
Expected complexity level and risk
Testing
cargo fmt --all --checkcargo check -p spacetimedb-clicargo test -p spacetimedb-cli --libspacetime login --auth-host https://maincloud.staging.spacetimedb.com --no-browser