chore: update related tags input removes inline style#306
Draft
kevinsmaster5 wants to merge 2 commits into
Draft
chore: update related tags input removes inline style#306kevinsmaster5 wants to merge 2 commits into
kevinsmaster5 wants to merge 2 commits into
Conversation
chore: add testing to related collection component chore: formatting cleanup
kevinsmaster5
commented
May 22, 2026
Contributor
Author
There was a problem hiding this comment.
I think I might refactor and break out some utilities. It's rather hefty. 🏋️
kevinsmaster5
commented
May 22, 2026
| })() | ||
|
|
||
| return () => controller.abort() | ||
| }, [primaryCollectionSlug, selectedIDs.join('|'), labelField, locale, fetchDocs]) |
Contributor
Author
There was a problem hiding this comment.
got some lint warnings I need to look into
375:6 Warning: React Hook useEffect has a missing dependency: 'selectedIDs'. Either include it or remove the dependency array. react-hooks/exhaustive-deps
375:30 Warning: React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked. react-hooks/exhaustive-deps
Contributor
Author
|
todo: see about adding eslint rules to flag inline style attribute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/cloud-gov/private/issues/2926
Changes proposed in this pull request:
Screenshots
shown with selected tags in place
showing menu open
no selected tags
menu open - no selected tags
create new tag
editing tag
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
[Note the any security considerations here, or make note of why there are none]