fix: use subtle for constant-time comparison#784
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Daphne's hand-rolled
constant_time_eq()helper withsubtle::ConstantTimeEq, which is already available through the workspace anddaphnecrate dependencies. The public helper keeps the same&[u8] -> boolAPI, so existing bearer-token and request-body comparison call sites do not need to change.This also addresses the related Prio3 count TODO by converting valid count measurements to
boolwithConstantTimeEqbefore sharding. Non-binary count measurements still follow the existing rejection path.Tests
cargo fmt --checkcargo test -p daphne constant_time_eq_matches_slice_equalitycargo test -p daphne count_rejects_non_binary_measurementcargo test -p daphne --libgit diff --checkCloses #247.