fix(manifests): tolerate objects without a trailing newline#42
Merged
muff1nman merged 1 commit intoJul 6, 2026
Merged
Conversation
The release job renders stable.yaml/cluster.yaml by concatenating each object after an `echo '---'`. When a source object lacks a trailing newline the following separator lands on that object's last line (e.g. `name: sciuro-leader---`), yielding a stream that strict YAML parsers reject with a duplicate-key error. Append a newline after any object that lacks one so the separator always starts its own line. Reviewed-by: Andrew DeMaria
terinjokes
approved these changes
Jul 6, 2026
ethan-gallant
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job renders stable.yaml/cluster.yaml by concatenating each object after an
echo '---'. When a source object lacks a trailing newline the following separator lands on that object's last line (e.g.name: sciuro-leader---), yielding a stream that strict YAML parsers reject with a duplicate-key error. Append a newline after any object that lacks one so the separator always starts its own line.Reviewed-by: Andrew DeMaria