Skip to content

chore: move test helper functions to conftest.py - #157

Open
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/common-test-helpers
Open

chore: move test helper functions to conftest.py#157
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/common-test-helpers

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

Moves test helper functions from test_bindings.py to conftest.py so that we can reuse them in other test suites (e.g. in #147)

@ask-bonk

ask-bonk Bot commented Jul 27, 2026

Copy link
Copy Markdown

I've reviewed the entire PR thoroughly. The changes are a clean mechanical refactoring:

  • Helper functions, types, and fixtures moved from test_bindings.py to conftest.py
  • Functions appropriately generalized (e.g., discover_suites takes src_dir parameter, dev_server takes worker_project_dir fixture)
  • Type/function names generalized from binding-specific to generic (e.g., BindingTestResult -> InWorkerTestResult)
  • The worker_project_dir fixture override pattern is correct pytest behavior
  • @functools.cache on get_suite_results is safe across modules since cache keys include the URL with unique port
  • No behavioral changes, no logic bugs, no security concerns

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant