Restore the listing and export flag docs - #30
Merged
Conversation
The three listing commands took flags the reference never mentioned, including the one that governs whether a secret appears at all: a secret whose newest version has been deleted is left out unless -q is given, even when an older version of it is still readable.
Both flags change which secrets come out, not only how many versions of each, and neither was described in the reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two documentation commits from #29 are not on
develop.#29 was stacked on
ls-escaped-pathsand was never retargeted, so mergingit put its commits on that branch — which #28 had already merged a moment
earlier — rather than on
develop. GitHub reports #29 as merged, and it is:into a branch nothing reads.
git merge-base --is-ancestor d67732d origin/developsays no.This cherry-picks the two commits onto
developunchanged. The content isthe one that was reviewed in #29:
the flags on
ls,tree, andpaths, including the liveness check thatdecides whether a secret is listed at all, and what
-qskipswhat
export -aand-deach change, measured against a live Vaultrather than inferred from the help text —
-dalso pulls in secrets aplain export skips entirely, which the help text does not say
No code changes, so nothing to verify beyond
make check, which is green.