CI fix windows integration test failures#435
Conversation
Fix ShrinkRootPartition to reliably free space on stemcell 2019.99 On stemcell 2019.99 the gap between SizeMin (~29.05 GB) and the partition size (~30 GB) is only ~950 MB. The previous approach used SizeMin + 1 GB as the target, which exceeded SizeMax (= CurrentSize) and caused Resize-Partition to fail with "Size Not Supported". A later attempt used SizeMax - 10 GB, which fell below SizeMin and caused Resize-Partition to silently return exit code 0 without making any change (LargestFreeExtent remained 0). Fix by shrinking 200 MB from the current partition size: - Uses (Get-Partition).Size (current size) instead of SizeMax, so we always shrink even when there is adjacent unallocated space. - 200 MB is well within the achievable range (~950 MB gap) and well above the agent's 1 MB minimum for creating an ephemeral partition. - Small amount means minimal data movement and fast completion. Also remove the agent-windows-large-root-disk.yml ops file added as a workaround: the AWS CPI ignores root_disk in instance-group-level cloud_properties, so the disk remained at 30 GB regardless. The ops file is no longer needed with the corrected shrink strategy. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughThis PR removes the 100GB disk override for Windows integration test deployments. The Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fix ShrinkRootPartition to reliably free space on stemcell 2019.99
On stemcell 2019.99 the gap between SizeMin (~29.05 GB) and the partition size (~30 GB) is only ~950 MB. The previous approach used SizeMin + 1 GB as the target, which exceeded SizeMax (= CurrentSize) and caused Resize-Partition to fail with "Size Not Supported". A later attempt used SizeMax - 10 GB, which fell below SizeMin and caused Resize-Partition to silently return exit code 0 without making any change (LargestFreeExtent remained 0).
Fix by shrinking 200 MB from the current partition size:
Also remove the agent-windows-large-root-disk.yml ops file added as a workaround: the AWS CPI ignores root_disk in instance-group-level cloud_properties, so the disk remained at 30 GB regardless. The ops file is no longer needed with the corrected shrink strategy.